Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed upper casing and added the deliveredFailed that was missing #1356

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fixed upper casing and added the deliveredFailed that was missing #1356

merged 2 commits into from
Dec 19, 2024

Conversation

Thurfjell
Copy link
Collaborator

@Thurfjell Thurfjell commented Dec 19, 2024 •
edited
Loading

Ticket:

Description

added missing key/value in english translate json, and normalised the other values to not be uppercase

Type

  • Dependency upgrade
  • Bug fix
  • New feature
  • Dev change
  • Additional tests
  • Documentation
  • Other

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • This change might impact the developer experience of others and should be communicated

Screenshots:

N/A

@Thurfjell Thurfjell merged commit 1c9ac9b into dev Dec 19, 2024
29 checks passed
@Thurfjell Thurfjell deleted the fix/messaging-event-status-delivery-failed branch December 19, 2024 13:47
David-Losinski pushed a commit that referenced this pull request Dec 19, 2024
@Thurfjell @David-Losinski
fixed upper casing and added the deliveredFailed that was missing (#1356
829df6f 
)
David-Losinski added a commit that referenced this pull request Jan 6, 2025
@David-Losinski @SamSalvatico @Thurfjell
recreate accessibility test brach due to merge issues (#1353)
fcc9e6b 
* recreate accessibility test bach due to merge issues

* files missed in recreating branch

* url update

* update package-lock.json

* fix(messaging): downgrade to 3.5.0 again (#1355)

* fixed upper casing and added the deliveredFailed that was missing (#1356)

* fix linting issues

* remove loging to console when report generation fails due to bearer scan issues

* regenerate package lock folloing merge conflicts

---------

Co-authored-by: SamSalvatico <[email protected]>
Co-authored-by: Ludwig Thufjell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteolc matteolc matteolc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thurfjell @matteolc