Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Journeys] Add filters to journeys list #1358

Merged
merged 10 commits into from
Jan 7, 2025
Merged

[Journeys] Add filters to journeys list #1358

merged 10 commits into from
Jan 7, 2025

Conversation

peschina
Copy link
Collaborator

@peschina peschina commented Dec 19, 2024 •
edited
Loading

Ticket:

Description

Add search option and time range filters to journeys list page.
PR with schema update merged in building blocks sdk.

Type

  • Dependency upgrade
  • Bug fix
  • New feature
  • Dev change
  • Additional tests
  • Documentation
  • Other

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • This change might impact the developer experience of others and should be communicated

Screenshots:

Screenshot 2024-12-19 at 16 13 39
Screenshot 2024-12-19 at 16 13 56
Screenshot 2024-12-19 at 16 14 36

@peschina peschina changed the title 23985 journeys filters [Journeys] Add filters to journeys list Dec 19, 2024
alfonsograziano
alfonsograziano previously approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@alfonsograziano alfonsograziano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also in this case there are a couple of files with missing EOF, but not a blocker

alfonsograziano
alfonsograziano approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@alfonsograziano alfonsograziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peschina peschina merged commit bcec9ef into dev Jan 7, 2025
28 checks passed
@peschina peschina deleted the 23985-journeys-filters branch January 7, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsograziano alfonsograziano alfonsograziano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peschina @alfonsograziano