Allow custom amount in payment form #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsograziano
force-pushed
the
allow-custom-amount
branch
from
bb048dc to
35a6171
Compare
peschina
reviewed
Mar 20, 2024
| <form style={{ maxWidth: "500px" }} action={selectAmountAction}> | ||
| <div className="govie-input__wrapper"> | ||
| <div aria-hidden="true" className="govie-input__prefix"> | ||
| {tCommon("currencySymbol")} |
There was a problem hiding this comment.
Will we always have the same currency?
There was a problem hiding this comment.
I guess currency will always be initially just Euros since is the legal currency in Ireland, but thanks for raising it. We should probably talk with Tamara about that soon :)
apps/payments/app/[locale]/(embedded)/paymentRequest/pay/page.tsx
Outdated
Show resolved
Hide resolved
alfonsograziano
force-pushed
the
allow-custom-amount
branch
from
c07f2f9 to
d224ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First basic implementation for 14576
Screen.Recording.2024-03-19.at.17.24.51.mov