logger: send warning messages to stderr (iterative#2612)

* logger: send warning messages to stderr Fix iterative#2561 * logger: filter warnings for stdout
ogigoc · Oct 16, 2019 · 13a7e0f · 13a7e0f
1 parent 0bfb3c0
commit 13a7e0f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/dvc/logger.py b/dvc/logger.py
@@ -19,7 +19,7 @@ def __init__(self, record):
 
 class ExcludeErrorsFilter(logging.Filter):
     def filter(self, record):
-        return record.levelno < logging.ERROR
+        return record.levelno < logging.WARNING
 
 
 class ColorFormatter(logging.Formatter):
@@ -182,7 +182,7 @@ def setup(level=logging.INFO):
                 },
                 "console_errors": {
                     "class": "dvc.logger.LoggerHandler",
-                    "level": "ERROR",
+                    "level": "WARNING",
                     "formatter": "color",
                     "stream": "ext://sys.stderr",
                 },

diff --git a/tests/unit/test_logger.py b/tests/unit/test_logger.py
@@ -179,3 +179,10 @@ def test_progress_awareness(self, mocker, capsys, caplog):
                     logger.info("some info")
                     captured = capsys.readouterr()
                     assert captured.out == ""
+
+
+def test_handlers():
+    stdout, stderr = logger.handlers
+
+    assert stdout.level == logging.DEBUG
+    assert stderr.level == logging.WARNING