Fix: Added cancel button in ValueSetForm

[abhijeetkhokhar]

Proposed Changes

• Fixes Create New ValueSet should have a cancel button #10897
• Added cancel button

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features

  • Introduced a cancel button that allows users to easily abort their action and return to the overview.

• UI Improvements

  • Redesigned the button area by aligning the submit and cancel buttons side by side, enhancing clarity and control.

[coderabbitai]

Walkthrough

The pull request modifies the ValueSetForm component by adding a new cancel button alongside the existing submit button, organized within a flex container for horizontal alignment. The cancel button utilizes the goBack function from useAppHistory for programmatic navigation. These changes enhance the user interface by allowing users to cancel their actions while maintaining the functionality of the submit button.

Changes

File	Summary Changes
src/components/ValueSet/ValueSetForm.tsx	Added new import: useAppHistory for navigation; introduced a new cancel button with outline styling; revised layout to group cancel and submit buttons in a flex container.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ValueSetForm
    participant Router

    User->>ValueSetForm: Click "Cancel" button
    ValueSetForm->>Router: Call goBack()
    Router-->>User: Render /admin/valuesets page

Loading

Possibly related PRs

• Fixes: added-cencel-button-in-questionnaire-location_edit #10826: Related changes in the ValueSetForm component, which include the addition of a cancel button and modifications to button layout.
• Cancel button fix in Book Appointment screen #9757: Changes that involve the addition of a goBack function from the useAppHistory hook to enhance the functionality of cancel buttons in their respective components.
• Fix: Pressing “Enter” After Entering Data in Patient Registration Form Refreshes #9655: Modifications in the PatientRegistration component that also involve changes to button behavior and type, enhancing user experience in form interactions.

Suggested labels

tested

Suggested reviewers

• Jacobjeevan
• rithviknishad

Poem

I'm a bunny, hopping with glee,
A new cancel button now sets me free.
With a hop to /admin/valuesets, I dash away,
Flex buttons in line, leading the way.
Coding carrots crunch as I celebrate this day!
🥕🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b57e94 and e8cd492.

📒 Files selected for processing (1)

• src/components/ValueSet/ValueSetForm.tsx (3 hunks)

🔇 Additional comments (3)

src/components/ValueSet/ValueSetForm.tsx (3)

30-31: LGTM - Proper import of the navigation hook.

Good addition of the useAppHistory hook for managing programmatic navigation when canceling the form.

---

404-405: LGTM - Properly destructured the goBack function.

Correctly destructured the goBack function from useAppHistory which will provide better navigation control.

---

495-507: LGTM - Well-implemented cancel button with proper layout.

The cancel button implementation follows best practices:

• Uses flex layout for proper button positioning
• Has type="button" to prevent form submission (addressing previous feedback)
• Uses the goBack function with a fallback URL (addressing previous feedback)
• No icon as requested in previous feedback
• Properly internationalized with t() function
• Disabled state handled correctly

The submit button is properly placed alongside the cancel button while maintaining its original functionality.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	e8cd492
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67c31b8ca635bc0008b58d3e
😎 Deploy Preview	https://deploy-preview-10916.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39bb22a and 3205a4b.

📒 Files selected for processing (1)

• src/components/ValueSet/ValueSetForm.tsx (2 hunks)

🔇 Additional comments (2)

src/components/ValueSet/ValueSetForm.tsx (2)

5-5: Appropriate import for navigation functionality.

The navigate import from "raviger" is correctly added for programmatic navigation needed by the cancel button.

---

11-11: Appropriate import for UI enhancement.

The CareIcon import is correctly added to provide visual feedback in the cancel button.

[rithviknishad]

lgtm, minor thing

[rithviknishad]

missed this earlier;

[github-actions]

@abhijeetkhokhar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌