Skip to content

Commit

Permalink
Rename WallMountedBox to _WallMountedBox
Browse files Browse the repository at this point in the history
as it is an abstract class and should not appear in the list of generators.

Thanks to https://github.com/HaSHsss for reporting!

Resolves: florianfesti#408
  • Loading branch information
florianfesti committed Jun 22, 2022
1 parent ad056de commit 277e0f2
Show file tree
Hide file tree
Showing 13 changed files with 26 additions and 26 deletions.
4 changes: 2 additions & 2 deletions boxes/generators/wallcaliperholder.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class WallCaliper(WallMountedBox):
class WallCaliper(_WallMountedBox):
"""Holds a single caliper to a wall"""

def __init__(self):
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/wallchiselholder.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class FrontEdge(edges.Edge):

Expand All @@ -33,7 +33,7 @@ def __call__(self, length, **kw):



class WallChiselHolder(WallMountedBox):
class WallChiselHolder(_WallMountedBox):
"""Wall tool holder for chisels, files and similar tools"""

def __init__(self):
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/wallconsole.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class WallConsole(WallMountedBox):
class WallConsole(_WallMountedBox):
"""Outset and angled plate to mount stuff to"""

def __init__(self):
Expand Down
6 changes: 3 additions & 3 deletions boxes/generators/walldrillbox.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@

from boxes import *
from .drillstand import DrillStand
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class WallDrillBox(DrillStand, WallMountedBox):
class WallDrillBox(DrillStand, _WallMountedBox):
"""Box for drills with each compartment with a different height"""

def __init__(self):
WallMountedBox.__init__(self) # don't call DrillStand.__init__
_WallMountedBox.__init__(self) # don't call DrillStand.__init__

self.addSettingsArgs(edges.StackableSettings, height=1.0, width=3)
self.buildArgParser(sx="25*6", sy="10:20:30", sh="25:40:60")
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/walledges.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class WallEdges(WallMountedBox):
class WallEdges(_WallMountedBox):
"""Shows the different edge types for wall systems"""

def __init__(self):
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/wallpinrow.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class PinEdge(edges.BaseEdge):
def __call__(self, length, **kw):
Expand All @@ -37,7 +37,7 @@ def __call__(self, length, **kw):
def margin(self):
return self.settings.thickness+self.settings.pinlength

class WallPinRow(WallMountedBox):
class WallPinRow(_WallMountedBox):
"""Outset and angled plate to mount stuff to"""

def __init__(self):
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/wallplaneholder.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class WallPlaneHolder(WallMountedBox):
class WallPlaneHolder(_WallMountedBox):
"""Hold a plane to a wall"""

def __init__(self):
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/wallpliersholder.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class WallPliersHolder(WallMountedBox):
class WallPliersHolder(_WallMountedBox):
"""Bar to hang pliers on"""

def __init__(self):
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/wallslottedholder.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class FrontEdge(edges.Edge):

Expand All @@ -30,7 +30,7 @@ def __call__(self, length, **kw):
self.polyline(w, (90, r1), ds-r1-r2, (-90, r2), ws-2*r2,
(-90, r2), ds-r1-r2, (90, r1), w)

class WallSlottedHolder(WallMountedBox):
class WallSlottedHolder(_WallMountedBox):
"""Wall tool holder with slots"""

def __init__(self):
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/wallstairs.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class WallStairs(WallMountedBox):
class WallStairs(_WallMountedBox):
"""Platforms in different heights e.g. for screw drivers"""

description = """You are supposed to add holes or slots to the stair tops yourself using Inkscape or another vector drawing or CAD program.
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/walltypetray.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

from boxes import *
from boxes.lids import _TopEdge
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class WallTypeTray(WallMountedBox, _TopEdge):
class WallTypeTray(_WallMountedBox, _TopEdge):
"""Type tray - allows only continuous walls"""

def __init__(self):
Expand Down
4 changes: 2 additions & 2 deletions boxes/generators/wallwrenchholder.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from boxes import *
from boxes.walledges import WallMountedBox
from boxes.walledges import _WallMountedBox

class SlottedEdge(edges.Edge):

Expand All @@ -42,7 +42,7 @@ def __call__(self, length, **kw):
self.polyline(0, -45)
self.edge(length-l)

class WallWrenchHolder(WallMountedBox):
class WallWrenchHolder(_WallMountedBox):
"""Hold a set of wrenches at a wall"""


Expand Down
2 changes: 1 addition & 1 deletion boxes/walledges.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from .edges import Settings, BaseEdge
from boxes import Boxes, edges

class WallMountedBox(Boxes):
class _WallMountedBox(Boxes):
ui_group = "WallMounted"

def __init__(self):
Expand Down

0 comments on commit 277e0f2

Please sign in to comment.