Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grunt node-webkit build util #157

Closed
wants to merge 4 commits into from
Closed

grunt node-webkit build util #157

wants to merge 4 commits into from

Conversation

nightink
Copy link

No description provided.

@ziadkh0
Copy link
Collaborator

ziadkh0 commented Jan 23, 2014

@nightink thank you for this contribution.
I'd like to add the link to the doc for grunt-node-webkit-builder.
And if you can add an icon for the mac app, it be awesome.

And I think we can't merge it to master so it be better if you could do the same changes in a separate branch.

Thanks again.
Cheers

@nightink
Copy link
Author

OK, I pushed again grunt-node-webkit-builder branch?

Ziad Khoury Hanna [email protected]:

@nightink thank you for this contribution.
I'd like to add the link to the doc for grunt-node-webkit-builder.
And if you can add an icon for the mac app, it be awesome.

And I think we can't merge it to master so it be better if you could do the same changes in a separate branch.

Thanks again.
Cheers


Reply to this email directly or view it on GitHub.

@ziadkh0
Copy link
Collaborator

ziadkh0 commented Jan 25, 2014

Hi @nightink,
thanks again for your work, I merged manually into concepts/build-automation-using-grunt branch.
And if @oklai agrees it can get merged into master.

Cheers

@nightink
Copy link
Author

Thk @zaygraveyard
Cheers

@nightink nightink closed this Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants