op-node: Fix span batch decode/encode logic error

okx · Dec 5, 2023 · 53dcf4b · 53dcf4b
1 parent 1e751d4
commit 53dcf4b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/op-node/rollup/derive/span_batch.go b/op-node/rollup/derive/span_batch.go
@@ -76,7 +76,7 @@ func (bp *spanBatchPayload) decodeOriginBits(r *bytes.Reader) error {
 	originBits := new(big.Int)
 	for i := 0; i < int(bp.blockCount); i += 8 {
 		end := i + 8
-		if end < int(bp.blockCount) {
+		if end > int(bp.blockCount) {
 			end = int(bp.blockCount)
 		}
 		bits := originBitBuffer[i/8]
@@ -302,7 +302,7 @@ func (bp *spanBatchPayload) encodeOriginBits(w io.Writer) error {
 	originBitBuffer := make([]byte, originBitBufferLen)
 	for i := 0; i < int(bp.blockCount); i += 8 {
 		end := i + 8
-		if end < int(bp.blockCount) {
+		if end > int(bp.blockCount) {
 			end = int(bp.blockCount)
 		}
 		var bits uint = 0

diff --git a/op-node/rollup/derive/span_batch_txs.go b/op-node/rollup/derive/span_batch_txs.go
@@ -48,7 +48,7 @@ func (btx *spanBatchTxs) encodeContractCreationBits(w io.Writer) error {
 	contractCreationBitBuffer := make([]byte, contractCreationBitBufferLen)
 	for i := 0; i < int(btx.totalBlockTxCount); i += 8 {
 		end := i + 8
-		if end < int(btx.totalBlockTxCount) {
+		if end > int(btx.totalBlockTxCount) {
 			end = int(btx.totalBlockTxCount)
 		}
 		var bits uint = 0
@@ -81,7 +81,7 @@ func (btx *spanBatchTxs) decodeContractCreationBits(r *bytes.Reader) error {
 	contractCreationBits := new(big.Int)
 	for i := 0; i < int(btx.totalBlockTxCount); i += 8 {
 		end := i + 8
-		if end < int(btx.totalBlockTxCount) {
+		if end > int(btx.totalBlockTxCount) {
 			end = int(btx.totalBlockTxCount)
 		}
 		bits := contractCreationBitBuffer[i/8]
@@ -173,7 +173,7 @@ func (btx *spanBatchTxs) encodeYParityBits(w io.Writer) error {
 	yParityBitBuffer := make([]byte, yParityBitBufferLen)
 	for i := 0; i < int(btx.totalBlockTxCount); i += 8 {
 		end := i + 8
-		if end < int(btx.totalBlockTxCount) {
+		if end > int(btx.totalBlockTxCount) {
 			end = int(btx.totalBlockTxCount)
 		}
 		var bits uint = 0
@@ -260,7 +260,7 @@ func (btx *spanBatchTxs) decodeYParityBits(r *bytes.Reader) error {
 	yParityBits := new(big.Int)
 	for i := 0; i < int(btx.totalBlockTxCount); i += 8 {
 		end := i + 8
-		if end < int(btx.totalBlockTxCount) {
+		if end > int(btx.totalBlockTxCount) {
 			end = int(btx.totalBlockTxCount)
 		}
 		bits := yParityBitBuffer[i/8]