Skip to content

Commit

Permalink
macvlan/macvtap: Fix unicast between macvtap interfaces in bridge mode
Browse files Browse the repository at this point in the history
Packets should always be forwarded to the lowerdev using dev_forward_skb.
vlan->forward is for packets being forwarded directly to another macvlan/
macvtap device (used for multicast in bridge mode).

Reported-and-tested-by: Shlomo Pongratz <[email protected]>
Signed-off-by: David Ward <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
dpward authored and davem330 committed Oct 5, 2011
1 parent 976d167 commit cb2d0f3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/macvlan.c
Original file line number Diff line number Diff line change
@@ -239,7 +239,7 @@ static int macvlan_queue_xmit(struct sk_buff *skb, struct net_device *dev)
dest = macvlan_hash_lookup(port, eth->h_dest);
if (dest && dest->mode == MACVLAN_MODE_BRIDGE) {
/* send to lowerdev first for its network taps */
vlan->forward(vlan->lowerdev, skb);
dev_forward_skb(vlan->lowerdev, skb);

return NET_XMIT_SUCCESS;
}

0 comments on commit cb2d0f3

Please sign in to comment.