Skip to content

Commit

Permalink
sfc: stop setting dev_port
Browse files Browse the repository at this point in the history
Setting dev_port changes the device names allocated by systemd. Any devices
with a dev_port >0 will (in default distro configurations) have a suffix of
"d<port-number>" appended.

This is not something done by other drivers, and causes confusion for users.

Fixes: 8be4132 ("sfc: Add code to export port_num in netdev->dev_port")
Signed-off-by: Edward Cree <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
sf-hgk authored and davem330 committed Jan 10, 2017
1 parent ac019f0 commit 0d71a84
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/ethernet/sfc/ef10.c
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,6 @@ static DEVICE_ATTR(primary_flag, 0444, efx_ef10_show_primary_flag, NULL);
static int efx_ef10_probe(struct efx_nic *efx)
{
struct efx_ef10_nic_data *nic_data;
struct net_device *net_dev = efx->net_dev;
int i, rc;

/* We can have one VI for each 8K region. However, until we
Expand Down Expand Up @@ -637,7 +636,6 @@ static int efx_ef10_probe(struct efx_nic *efx)
if (rc < 0)
goto fail5;
efx->port_num = rc;
net_dev->dev_port = rc;

rc = efx->type->get_mac_address(efx, efx->net_dev->perm_addr);
if (rc)
Expand Down

0 comments on commit 0d71a84

Please sign in to comment.