Skip to content

Commit

Permalink
ext4: fix missing call to trace_ext4_ext_map_blocks_exit
Browse files Browse the repository at this point in the history
When ext4_ext_handle_uninitialized_extents(), we will directly return
from ext4_ext_map_blocks().  The trace point of
trace_ext4_ext_map_blocks_exit isn't called, and the user doesn't see
any result.  This patch tries to fix this problem.

Meanwhile in ext4_ext_handle_uninitialized_extents it returns errors
or the number of allocated blocks.  So 'ret' variable can be removed
due to previously modifications.

Signed-off-by: Zheng Liu <[email protected]>
  • Loading branch information
gnehzuil authored and tytso committed Nov 8, 2012
1 parent 19b303d commit 3779473
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions fs/ext4/extents.c
Original file line number Diff line number Diff line change
Expand Up @@ -3911,7 +3911,7 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
struct ext4_extent newex, *ex, *ex2;
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
ext4_fsblk_t newblock = 0;
int free_on_err = 0, err = 0, depth, ret;
int free_on_err = 0, err = 0, depth;
unsigned int allocated = 0, offset = 0;
unsigned int allocated_clusters = 0;
struct ext4_allocation_request ar;
Expand Down Expand Up @@ -4007,10 +4007,10 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
ee_len, ee_start);
goto out;
}
ret = ext4_ext_handle_uninitialized_extents(
allocated = ext4_ext_handle_uninitialized_extents(
handle, inode, map, path, flags,
allocated, newblock);
return ret;
goto out3;
}
}

Expand Down Expand Up @@ -4284,6 +4284,7 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
kfree(path);
}

out3:
trace_ext4_ext_map_blocks_exit(inode, map, err ? err : allocated);

return err ? err : allocated;
Expand Down

0 comments on commit 3779473

Please sign in to comment.