xfrm: properly handle invalid states as an error

The error exit path needs err explicitly set. Otherwise it returns success and the only caller, xfrm_output_resume(), would oops in skb_dst(skb)->ops derefence as skb_dst(skb) is NULL. Bug introduced in commit bb65a9c (xfrm: removes a superfluous check and add a statistic). Signed-off-by: Timo Teräs <[email protected]> Cc: Li RongQing <[email protected]> Cc: Steffen Klassert <[email protected]> Signed-off-by: David S. Miller <[email protected]>
olifre · May 23, 2013 · 497574c · 497574c
1 parent e416662
commit 497574c
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
@@ -64,6 +64,7 @@ static int xfrm_output_one(struct sk_buff *skb, int err)
 
 		if (unlikely(x->km.state != XFRM_STATE_VALID)) {
 			XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTSTATEINVALID);
+			err = -EINVAL;
 			goto error;
 		}