Skip to content

Commit

Permalink
Fix init/main.c to use regular printk with '%pF' for initcall fn
Browse files Browse the repository at this point in the history
.. small detail, but the silly e1000e initcall warning debugging caused
me to look at this code.  Rather than gouge my eyes out with a spoon, I
just fixed it.

Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
torvalds committed Oct 3, 2008
1 parent 95b866d commit 96d746c
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions init/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ int do_one_initcall(initcall_t fn)
int result;

if (initcall_debug) {
print_fn_descriptor_symbol("calling %s\n", fn);
printk("calling %pF\n", fn);
t0 = ktime_get();
}

Expand All @@ -718,8 +718,8 @@ int do_one_initcall(initcall_t fn)
t1 = ktime_get();
delta = ktime_sub(t1, t0);

print_fn_descriptor_symbol("initcall %s", fn);
printk(" returned %d after %Ld msecs\n", result,
printk("initcall %pF returned %d after %Ld msecs\n",
fn, result,
(unsigned long long) delta.tv64 >> 20);
}

Expand All @@ -737,8 +737,7 @@ int do_one_initcall(initcall_t fn)
local_irq_enable();
}
if (msgbuf[0]) {
print_fn_descriptor_symbol(KERN_WARNING "initcall %s", fn);
printk(" returned with %s\n", msgbuf);
printk("initcall %pF returned with %s\n", fn, msgbuf);
}

return result;
Expand Down

0 comments on commit 96d746c

Please sign in to comment.