hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV in…

…stead Removing unnecessary static buffers is good. Use the vsprintf %pV extension instead. Signed-off-by: Joe Perches <[email protected]> Signed-off-by: Mikulas Patocka <[email protected]> Cc: [email protected] # v2.6.36+ Signed-off-by: Linus Torvalds <[email protected]>
olifre · Jul 9, 2015 · a28e4b2 · a28e4b2
1 parent ce65761
commit a28e4b2
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
@@ -52,17 +52,20 @@ static void unmark_dirty(struct super_block *s)
 }
 
 /* Filesystem error... */
-static char err_buf[1024];
-
 void hpfs_error(struct super_block *s, const char *fmt, ...)
 {
+	struct va_format vaf;
 	va_list args;
 
 	va_start(args, fmt);
-	vsnprintf(err_buf, sizeof(err_buf), fmt, args);
+
+	vaf.fmt = fmt;
+	vaf.va = &args;
+
+	pr_err("filesystem error: %pV", &vaf);
+
 	va_end(args);
 
-	pr_err("filesystem error: %s", err_buf);
 	if (!hpfs_sb(s)->sb_was_error) {
 		if (hpfs_sb(s)->sb_err == 2) {
 			pr_cont("; crashing the system because you wanted it\n");