Skip to content

Commit

Permalink
ASoC: rt5514-spi: Let the buf_size to align with period_bytes
Browse files Browse the repository at this point in the history
The patch lets the buf_size to align with period_bytes to prevent the
buffer reading over the real size of the DSP buffer and also avoid to
calculate the wrong size of remaining data.

Signed-off-by: Oder Chiou <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
  • Loading branch information
oder-chiou authored and broonie committed Nov 8, 2017
1 parent 28aef24 commit c4a71ff
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions sound/soc/codecs/rt5514-spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,13 @@ static void rt5514_spi_copy_work(struct work_struct *work)

static void rt5514_schedule_copy(struct rt5514_dsp *rt5514_dsp)
{
size_t period_bytes;
u8 buf[8];

if (!rt5514_dsp->substream)
return;

period_bytes = snd_pcm_lib_period_bytes(rt5514_dsp->substream);
rt5514_dsp->get_size = 0;

/**
Expand Down Expand Up @@ -176,6 +181,10 @@ static void rt5514_schedule_copy(struct rt5514_dsp *rt5514_dsp)

rt5514_dsp->buf_size = rt5514_dsp->buf_limit - rt5514_dsp->buf_base;

if (rt5514_dsp->buf_size % period_bytes)
rt5514_dsp->buf_size = (rt5514_dsp->buf_size / period_bytes) *
period_bytes;

if (rt5514_dsp->buf_base && rt5514_dsp->buf_limit &&
rt5514_dsp->buf_rp && rt5514_dsp->buf_size)
schedule_delayed_work(&rt5514_dsp->copy_work, 0);
Expand Down

0 comments on commit c4a71ff

Please sign in to comment.