GEODE-1255: Add test coverage for using a custom log4j2.xml with Geode

* refactor launcher integration tests (rename files, use TemporaryFolder) * refactor cluster config tests (use TemporaryFolder) * change several additional tests to use TemporaryFolder * add better support for TemporaryFolder usage to HeadlessGfsh * alter HeadlessGfsh tests to use TemporaryFolder * rescope variables and methods to private where possible * fixup file formatting * prevent eating of exceptions * remove incomplete or useless javadocs * rename LocatorJUnitTest test methods from TRAC #s to meaningful names
omallassi · May 5, 2016 · 566fce9 · 566fce9
1 parent 024cd22
commit 566fce9
Show file tree

Hide file tree

Showing 59 changed files with 2,849 additions and 1,936 deletions.
diff --git a/...ted/LocatorLauncherAssemblyJUnitTest.java → ...catorLauncherAssemblyIntegrationTest.java b/...ted/LocatorLauncherAssemblyJUnitTest.java → ...catorLauncherAssemblyIntegrationTest.java
@@ -38,10 +38,9 @@
 
 /**
  * These tests are part of assembly as they require the REST war file to be present.
- *
  */
 @Category(IntegrationTest.class)
-public class LocatorLauncherAssemblyJUnitTest extends AbstractLocatorLauncherJUnitTestCase {
+public class LocatorLauncherAssemblyIntegrationTest extends AbstractLocatorLauncherIntegrationTestCase {
 
   @Before
   public final void setUpLocatorLauncherLocalTest() throws Exception {

diff --git a/...stone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java b/...stone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java b/geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java
@@ -303,10 +303,6 @@ public Resource getResource(){
     return Resource.NULL;
   }
 
-  /**
-   *
-   * @return
-   */
   public String getRegionName(){
     return "NULL";
   }