Skip to content

Commit

Permalink
method parameter consistancy. always use KEY session_index as first p…
Browse files Browse the repository at this point in the history
…arameter, session_id as second value parameter
  • Loading branch information
j1n6 committed Dec 13, 2013
1 parent df4662b commit 916dfaf
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions app/controllers/devise/cas_sessions_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ def single_sign_out
logger.debug "Intercepted single-sign-out request for CAS session #{session_index}."
session_id = ::DeviseCasAuthenticatable::SingleSignOut::Strategies.current_strategy.find_session_id_by_index(session_index)
if session_id
destroy_cas_session(session_id, session_index)
logger.debug "Found Session ID #{session_id} with index key #{session_index}"
destroy_cas_session(session_index, session_id)
end
else
logger.warn "Ignoring CAS single-sign-out request as no session index could be parsed from the parameters."
Expand All @@ -64,12 +65,10 @@ def read_session_index
end
end

def destroy_cas_session(session_id, session_index)
logger.debug "Destroying cas session #{session_id} for ticket #{session_index}"
def destroy_cas_session(session_index, session_id)
if destroy_session_by_id(session_id)
logger.debug "Destroyed session #{session_id} corresponding to service ticket #{session_index}."
end

::DeviseCasAuthenticatable::SingleSignOut::Strategies.current_strategy.delete_session_index(session_index)
end

Expand Down

0 comments on commit 916dfaf

Please sign in to comment.