Don’t parse eg. 5.2-start as 5.2.0

omercinar300 · Dec 19, 2022 · 033232c · 033232c
1 parent 9e874bf
commit 033232c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/utils/semver.ts b/src/utils/semver.ts
@@ -14,7 +14,7 @@ export default class SemVer {
   minor: number
   patch: number
 
-  //FIXME
+  //FIXME parse these
   readonly prerelease: string[] = []
   readonly build: string[] = []
 
@@ -34,10 +34,12 @@ export default class SemVer {
           if (isNaN(n)) throw new Error(`invalid version: ${input}`)
           pretty_is_raw = true
           return [n, char_to_num(match[2])]
-        } else {
-          const n = parseInt(x)
+        } else if (/^\d+$/.test(x)) {
+          const n = parseInt(x)  // parseInt will parse eg. `5-start` to `5`
           if (isNaN(n)) throw new Error(`invalid version: ${input}`)
           return [n]
+        } else {
+          throw new Error(`invalid version: ${input}`)
         }
       })
       this.raw = input