Static L0 Loader Support #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
force-pushed
the
static_loader
branch
from
dcca4f4 to
222da8e
Compare
nrspruit
changed the title
nrspruit
force-pushed
the
static_loader
branch
2 times, most recently
from
62860db to
0397704
Compare
|
Issue #141 |
nrspruit
force-pushed
the
static_loader
branch
from
0397704 to
a9842e3
Compare
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
- Added support for older dii tables such that the version of the apis supported by that dynamic loader are requested and not newer versions. - Added check for backwards compatability for older init apis. Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
… loader build Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
static_loader
branch
from
acf49cf to
575a758
Compare
Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
static_loader
branch
from
575a758 to
faaa9e8
Compare
Signed-off-by: Neil R. Spruit <[email protected]>
rwmcguir
reviewed
Jan 29, 2025
| @@ -34,22 +36,130 @@ namespace ze_lib | |||
| context_t(); | |||
| ~context_t(); | |||
|
|
|||
| ////////////////////////////////////////////////////////////////////////// | |||
| std::string to_string(const ze_result_t result) { | |||
There was a problem hiding this comment.
is this coming from build time, else we have a maintenance nightmare?
There was a problem hiding this comment.
this is manual, we have no mako for this file right now.
rwmcguir
reviewed
Jan 29, 2025
| @@ -34,22 +36,130 @@ namespace ze_lib | |||
| context_t(); | |||
| ~context_t(); | |||
|
|
|||
| ////////////////////////////////////////////////////////////////////////// | |||
| std::string to_string(const ze_result_t result) { | |||
There was a problem hiding this comment.
This work, but have you considered using stringify w/preprocessor macros?
Which may also work to not miss future ZE_RESULT additions
Trying to avoid a future maintenance issue
There was a problem hiding this comment.
The generation of this code, which exists elsewhere, will be addressed in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static Loader Support.
This support has a few conditions: