Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portion of various fixes and minor improvements #2723

Merged
merged 10 commits into from
Feb 21, 2025
Merged

Portion of various fixes and minor improvements #2723

merged 10 commits into from
Feb 21, 2025

Conversation

dzarukin
Copy link
Contributor

Binary post-op check + improved verbose message for a single function is coming from MFDNN-13225.

Parser for engine improvement is coming from MFDNN-13218.

Doc and header fixes are coming from Nightly.

Clang-tidy fixes for CPU file.

@dzarukin dzarukin requested review from a team as code owners February 20, 2025 07:34
@dzarukin
Copy link
Contributor Author

make test

@github-actions github-actions bot added documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 component:api Codeowner: @oneapi-src/onednn-arch component:tests Codeowner: @oneapi-src/onednn-arch component:examples labels Feb 20, 2025
@dzarukin
Copy link
Contributor Author

make test

/// @param a_dt Data type of tensor A.
/// @param b_dt Data type of tensor B.
/// @param dt_a Data type of tensor A.
/// @param dt_b Data type of tensor B.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It seems like we have conflicting naming conventions being used in the external headers. For example, the opposite convention can be found here and here. To maintain consistency, could we just rename the variables in the function declaration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm putting this into my list of ukernel adjustments. Thanks for bringing this in.

@dzarukin dzarukin merged commit 4cf009c into main Feb 21, 2025
21 of 22 checks passed
@dzarukin dzarukin deleted the dzarukin/fixes branch February 21, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api Codeowner: @oneapi-src/onednn-arch component:examples component:tests Codeowner: @oneapi-src/onednn-arch documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants