-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portion of various fixes and minor improvements #2723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make test |
mgouicem
approved these changes
Feb 20, 2025
2b7c50b
to
c56f7da
Compare
make test |
densamoilov
reviewed
Feb 21, 2025
densamoilov
approved these changes
Feb 21, 2025
rjoursler
reviewed
Feb 21, 2025
/// @param a_dt Data type of tensor A. | ||
/// @param b_dt Data type of tensor B. | ||
/// @param dt_a Data type of tensor A. | ||
/// @param dt_b Data type of tensor B. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm putting this into my list of ukernel adjustments. Thanks for bringing this in.
rjoursler
approved these changes
Feb 21, 2025
vpirogov
approved these changes
Feb 21, 2025
Fixing documentation.
c56f7da
to
6228258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:api
Codeowner: @oneapi-src/onednn-arch
component:examples
component:tests
Codeowner: @oneapi-src/onednn-arch
documentation
A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc
platform:cpu-x64
Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary post-op check + improved verbose message for a single function is coming from MFDNN-13225.
Parser for engine improvement is coming from MFDNN-13218.
Doc and header fixes are coming from Nightly.
Clang-tidy fixes for CPU file.