Merge pull request apache#5242 from tbw777/unused2

Removed StringUtils unused object creation
onepiec1 · Jan 10, 2023 · cd14cf5 · cd14cf5
2 parents e5dd712 + 7e775d6
commit cd14cf5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/...t/engine/src/org/mycompany/installer/wizard/components/panels/PreInstallSummaryPanel.java b/...t/engine/src/org/mycompany/installer/wizard/components/panels/PreInstallSummaryPanel.java
@@ -210,13 +210,11 @@ protected void initialize() {
 
             installationSizeLabel.setText(
                     panel.getProperty(INSTALLATION_SIZE_PROPERTY));
-            installationSizeValue.setText(StringUtils.formatSize(
-                    installationSize));
+            installationSizeValue.setText(StringUtils.formatSize(installationSize));
 
             downloadSizeLabel.setText(
                     panel.getProperty(DOWNLOAD_SIZE_PROPERTY));
-            downloadSizeValue.setText(StringUtils.formatSize(
-                    downloadSize));
+            downloadSizeValue.setText(StringUtils.formatSize(downloadSize));
 
             if (registry.getProductsToInstall().size() == 0) {
                 locationsPane.setVisible(false);

diff --git a/...rc/org/netbeans/installer/wizard/components/panels/netbeans/NbPreInstallSummaryPanel.java b/...rc/org/netbeans/installer/wizard/components/panels/netbeans/NbPreInstallSummaryPanel.java
@@ -458,13 +458,11 @@ protected void initialize() {
 
             installationSizeLabel.setText(
                     panel.getProperty(INSTALLATION_SIZE_PROPERTY));
-            installationSizeValue.setText(StringUtils.formatSize(
-                    installationSize));
+            installationSizeValue.setText(StringUtils.formatSize(installationSize));
 
             downloadSizeLabel.setText(
                     panel.getProperty(DOWNLOAD_SIZE_PROPERTY));
-            downloadSizeValue.setText(StringUtils.formatSize(
-                    downloadSize));
+            downloadSizeValue.setText(StringUtils.formatSize(downloadSize));
 
             if (registry.getProductsToInstall().isEmpty()) {
                 locationsPane.setVisible(false);

diff --git a/nbi/engine/src/org/netbeans/installer/utils/StringUtils.java b/nbi/engine/src/org/netbeans/installer/utils/StringUtils.java
@@ -168,8 +168,6 @@ public static String getFilenameFromUrl(
 
     public static String formatSize(
             final long longBytes) {
-        StringBuffer result = new StringBuffer();
-
         double bytes = (double) longBytes;
 
         // try as GB