{CI} azdev style: Use azdev config files when .flake8 and pylintrc …

…are not found in azure cli/ext repo. (Azure#442)

* Update style.py

* update

* Update test_style.py

* Update test_style.py

* Update test_style.py

HISTORY.rst

@@ -2,6 +2,10 @@
 
 Release History
 ===============
+0.1.66
+++++++
+* `azdev style`: Use azdev config files when .flake8 and pylintrc are not found in azure cli/ext repo.
+
 0.1.65
 ++++++
 * `azdev command-change meta-diff`: Add diff support for deprecate_info in subgroup, cmd, parameters and options.

azdev/__init__.py

@@ -4,4 +4,4 @@
 # license information.
 # -----------------------------------------------------------------------------
 
-__VERSION__ = '0.1.65'
+__VERSION__ = '0.1.66'

azdev/operations/style.py

@@ -222,6 +222,12 @@ def _config_file_path(style_type="pylint"):
 
     if cli_repo_path:
         cli_config_path = os.path.join(cli_repo_path, config_file_mapping[style_type])
+        if not os.path.exists(cli_config_path):
+            cli_config_path = os.path.join(
+                get_azdev_config_dir(),
+                "config_files",
+                default_config_file_mapping["cli"][style_type],
+            )
     else:
         cli_config_path = os.path.join(
             get_azdev_config_dir(),
@@ -231,6 +237,12 @@ def _config_file_path(style_type="pylint"):
 
     if ext_repo_path:
         ext_config_path = os.path.join(ext_repo_path, config_file_mapping[style_type])
+        if not os.path.exists(ext_config_path):
+            ext_config_path = os.path.join(
+                get_azdev_config_dir(),
+                "config_files",
+                default_config_file_mapping["ext"][style_type],
+            )
     else:
         ext_config_path = os.path.join(
             get_azdev_config_dir(),

azdev/operations/tests/test_style.py

@@ -29,7 +29,7 @@ def test_pylint_config_without_setup(self):
             self.assertTrue(r[1].endswith("/config_files/ext_pylintrc"))
 
     def test_pylint_config_with_partially_setup(self):
-        cli_repo_path = "~/Azure/azure-cli"
+        cli_repo_path = "/mnt/vss/_work/1/s/azure-cli"
         mocked_config = configparser.ConfigParser()
         mocked_config.add_section("cli")
         mocked_config.set("cli", "repo_path", cli_repo_path)
@@ -42,8 +42,8 @@ def test_pylint_config_with_partially_setup(self):
             self.assertTrue(r[1].endswith("/config_files/ext_pylintrc"))
 
     def test_pylint_config_with_all_setup(self):
-        cli_repo_path = "~/Azure/azure-cli"
-        ext_repo_path = "~/Azure/azure-cli-extensions"
+        cli_repo_path = "/mnt/vss/_work/1/s/azure-cli"
+        ext_repo_path = "/mnt/vss/_work/1/s/azure-cli-extensions"
         mocked_config = configparser.ConfigParser()
         mocked_config.add_section("cli")
         mocked_config.set("cli", "repo_path", cli_repo_path)
@@ -53,7 +53,7 @@ def test_pylint_config_with_all_setup(self):
         with mock.patch("azdev.operations.style.get_azdev_config", return_value=mocked_config):
             r = _config_file_path()
             self.assertEqual(r[0], cli_repo_path + "/pylintrc")
-            self.assertTrue(r[1], "/pylintrc")
+            self.assertEqual(r[1], ext_repo_path + "/pylintrc")
 
     def test_flake8_config_wihtout_setup(self):
         mocked_config = configparser.ConfigParser()
@@ -68,7 +68,7 @@ def test_flake8_config_wihtout_setup(self):
             self.assertTrue(r[1].endswith("/config_files/ext.flake8"))
 
     def test_flake8_config_with_partially_setup(self):
-        ext_repo_path = "~/Azure/azure-cli-extensions"
+        ext_repo_path = "/mnt/vss/_work/1/s/azure-cli-extensions"
 
         mocked_config = configparser.ConfigParser()
         mocked_config.add_section("cli")
@@ -81,9 +81,9 @@ def test_flake8_config_with_partially_setup(self):
             self.assertTrue(r[0].endswith("/config_files/cli.flake8"))
             self.assertTrue(r[1].endswith(ext_repo_path + "/.flake8"))
 
-    def test_flake9_config_with_all_setup(self):
-        cli_repo_path = "~/Azure/azure-cli"
-        ext_repo_path = "~/Azure/azure-cli-extensions"
+    def test_flake8_config_with_all_setup(self):
+        cli_repo_path = "/mnt/vss/_work/1/s/azure-cli"
+        ext_repo_path = "/mnt/vss/_work/1/s/azure-cli-extensions"
 
         mocked_config = configparser.ConfigParser()
         mocked_config.add_section("cli")
@@ -95,3 +95,20 @@ def test_flake9_config_with_all_setup(self):
             r = _config_file_path(style_type="flake8")
             self.assertTrue(r[0].endswith(cli_repo_path + "/.flake8"))
             self.assertTrue(r[1].endswith(ext_repo_path + "/.flake8"))
+
+    def test_style_with_all_setup_but_not_exist(self):
+        cli_repo_path = "/fake/azure-cli"
+        ext_repo_path = "/fake/azure-cli-extensions"
+        mocked_config = configparser.ConfigParser()
+        mocked_config.add_section("cli")
+        mocked_config.set("cli", "repo_path", cli_repo_path)
+        mocked_config.add_section("ext")
+        mocked_config.set("ext", "repo_paths", ext_repo_path)
+
+        with mock.patch("azdev.operations.style.get_azdev_config", return_value=mocked_config):
+            r1 = _config_file_path(style_type="flake8")
+            r2 = _config_file_path(style_type="pylint")
+            self.assertTrue(r1[0].endswith("/config_files/cli.flake8"))
+            self.assertTrue(r1[1].endswith("/config_files/ext.flake8"))
+            self.assertTrue(r2[0].endswith("/config_files/cli_pylintrc"))
+            self.assertTrue(r2[1].endswith("/config_files/ext_pylintrc"))