Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure the whole name is shown #87

Closed
wants to merge 1 commit into from

Conversation

OmgImAlexis
Copy link

Before After
before after

@onury
Copy link
Owner

onury commented Jan 22, 2020

@OmgImAlexis thanks.

Using name.split(match[1])[1] as in your PR solves the problem for your case only.
If symbol name was Core.module:Core, you'd get .module:

The issue is the regex here.
It should have been /(.*?)([.#~].+)/g (to allow other characters such as -)

This is already fixed in the upcoming release.

@onury onury closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants