Fix API Secret, README, grammatic errors #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some grammar errors, and fix README markdown newlines Also fix API Secret input prompt so it now works properly. Added --silent to curl to omit the transmission log, should look a little cleaner.
|
唔……这个pull request太乱了，导致我分不清哪个是为了修正断行哪个是为了修正app secret的错误…… |
oott123
added a commit
that referenced
this pull request
Oct 20, 2013
Fix API Secret, README, grammatic errors
|
hmmm.... app secret那里其实我就是在[ ]中间把'.BPCSU_SEC.'加上了，然后就不跳过了=.= |
|
并不是这样的=-= issue #2 里有提到这个问题。我修复之后合并了一个分支，因为误操作又将错误的修复回滚了。 大致的意思是，PHP中的Where doc（也就是<<<EOF）的结束符EOF需要顶格写，我的编辑器给它加了一个tab符，自然就出问题了。 |
|
好吧，表示对PHP一窍不通 T.T |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前因为我的vim自动切掉了每一行最后的空格所以弄乱了README的markdown格式，修好了~
另外我说那个API Secret提示的问题，我试着这样改了一下就ok了，你看看~~
curl的output太乱了，加了--silent来把curl的传输过程省掉了
最后出来的json估计可以parse一下变得更加好看，不过我只知道python怎么整-.-~
Commit Message:
Fix some grammar errors, and fix README markdown newlines
Also fix API Secret input prompt so it now works properly.
Added --silent to curl to omit the transmission log, should look a
little cleaner.