-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SDK-250): denylist bot #115
Open
1Mateus
wants to merge
13
commits into
main
Choose a base branch
from
HYC-205-jasso-bot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Mateus
force-pushed
the
HYC-205-jasso-bot
branch
from
April 10, 2023 11:44
a1b4a25
to
c868841
Compare
1Mateus
force-pushed
the
HYC-205-jasso-bot
branch
from
April 11, 2023 01:45
0bc9bba
to
abc293f
Compare
veigajoao
requested changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is looking really solid. I pointed out a couple issues with the implementation that were not verified in tests.
Also pointed out some readability issues and improvements.
Please let me know how you feel about them before implementing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL to Jira task (this should explain the task)
https://hackachain.atlassian.net/browse/HYC-205?atlOrigin=eyJpIjoiYzJjMGIwYTNkYjRjNDMyNjg3NDAzNzM5YTg0ZTI3ZTYiLCJwIjoiaiJ9
Explain what the code alterations do
create new denylist bot
What has to be tested? How to test it?
execute yarn denylist test
Any new dependencies? Why were they added?
new denylist packages