Unify call graphs #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorunR
reviewed
Oct 11, 2021
| @@ -142,6 +166,8 @@ class CallGraphTests extends PropertiesTest { | |||
| } | |||
|
|
|||
| describe("the CTA call graph analysis is executed") { | |||
| cgKey = FTACallGraphKey | |||
There was a problem hiding this comment.
Shouldn't this be CTACallGraphKey?
There was a problem hiding this comment.
Thanks, will fix immediately.
| @@ -65,7 +66,8 @@ trait APIBasedAnalysis extends FPCFAnalysis { | |||
| caller.hasSingleDefinedMethod) { | |||
| newSeenCallers += ((caller, pc, isDirect)) | |||
|
|
|||
| results ::= handleNewCaller(caller.asDefinedMethod, pc, isDirect) | |||
| // FIXME The asInstanceOf obviously won't work once different context types are possible | |||
There was a problem hiding this comment.
Do you want to keep the fixme? Just checking
There was a problem hiding this comment.
Yes, this Fixme will be solved in an upcoming pull request that introduces context-sensitive CGs.
| import org.opalj.tac.fpcf.properties.TACAI | ||
|
|
||
| /** | ||
| * TODO: That state object is currently copy&paste and should be refactored. |
There was a problem hiding this comment.
Same as the fixme before: Do you want to leave this in?
There was a problem hiding this comment.
I guess this can be removed now, I think this PR already unifies the respective copies. Thank you.
TorunR
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies the different call graph algorithms to a single base algorithm that uses different
TypeProviders to resolve the possible receivers of virtual calls.This enables all call graph modules to fully utilize the precision of the different TypeProviders, including information on allocation sites where available (the reflection module does not use allocation site information in all places possible to avoid excessive complexity, but it uses it in the most important cases).
This pull request also includes preparations to allow for future context-sensitive call graphs by stringing context information along where necessary.