Allow to set IoRatio to 100%

opaopa6969 · Feb 12, 2014 · 0ad029b · 0ad029b
1 parent 4dc337a
commit 0ad029b
Showing 1 changed file with 20 additions and 11 deletions.
diff --git a/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java b/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
@@ -211,8 +211,8 @@ public int getIoRatio() {
      * {@code 50}, which means the event loop will try to spend the same amount of time for I/O as for non-I/O tasks.
      */
     public void setIoRatio(int ioRatio) {
-        if (ioRatio <= 0 || ioRatio >= 100) {
-            throw new IllegalArgumentException("ioRatio: " + ioRatio + " (expected: 0 < ioRatio < 100)");
+        if (ioRatio <= 0 || ioRatio > 100) {
+            throw new IllegalArgumentException("ioRatio: " + ioRatio + " (expected: 0 < ioRatio < 101)");
         }
         this.ioRatio = ioRatio;
     }
@@ -339,18 +339,19 @@ protected void run() {
                 }
 
                 cancelledKeys = 0;
-
-                final long ioStartTime = System.nanoTime();
                 needsToSelectAgain = false;
-                if (selectedKeys != null) {
-                    processSelectedKeysOptimized(selectedKeys.flip());
+                final int ioRatio = this.ioRatio;
+                if (ioRatio == 100) {
+                    processSelectedKeys();
+                    runAllTasks();
                 } else {
-                    processSelectedKeysPlain(selector.selectedKeys());
-                }
-                final long ioTime = System.nanoTime() - ioStartTime;
+                    final long ioStartTime = System.nanoTime();
 
-                final int ioRatio = this.ioRatio;
-                runAllTasks(ioTime * (100 - ioRatio) / ioRatio);
+                    processSelectedKeys();
+
+                    final long ioTime = System.nanoTime() - ioStartTime;
+                    runAllTasks(ioTime * (100 - ioRatio) / ioRatio);
+                }
 
                 if (isShuttingDown()) {
                     closeAll();
@@ -372,6 +373,14 @@ protected void run() {
         }
     }
 
+    private void processSelectedKeys() {
+        if (selectedKeys != null) {
+            processSelectedKeysOptimized(selectedKeys.flip());
+        } else {
+            processSelectedKeysPlain(selector.selectedKeys());
+        }
+    }
+
     @Override
     protected void cleanup() {
         try {