Tiny optimizations

opaopa6969 · Aug 9, 2013 · 1547876 · 1547876
1 parent e954eb1
commit 1547876
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
@@ -165,14 +165,14 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
         } catch (Throwable t) {
             throw new DecoderException(t);
         } finally {
-            if (out.isEmpty()) {
+            int size = out.size();
+            if (size == 0) {
                 decodeWasNull = true;
+            } else {
+                for (int i = 0; i < size; i ++) {
+                    ctx.fireChannelRead(out.get(i));
+                }
             }
-
-            for (int i = 0; i < out.size(); i ++) {
-                ctx.fireChannelRead(out.get(i));
-            }
-
             out.recycle();
         }
     }
@@ -207,8 +207,8 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
                 cumulation.release();
                 cumulation = null;
             }
-
-            for (int i = 0; i < out.size(); i ++) {
+            int size = out.size();
+            for (int i = 0; i < size; i ++) {
                 ctx.fireChannelRead(out.get(i));
             }
             ctx.fireChannelInactive();

diff --git a/codec/src/main/java/io/netty/handler/codec/MessageToMessageDecoder.java b/codec/src/main/java/io/netty/handler/codec/MessageToMessageDecoder.java
@@ -98,7 +98,8 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
         } catch (Exception e) {
             throw new DecoderException(e);
         } finally {
-            for (int i = 0; i < out.size(); i ++) {
+            int size = out.size();
+            for (int i = 0; i < size; i ++) {
                 ctx.fireChannelRead(out.get(i));
             }
             out.recycle();

diff --git a/codec/src/main/java/io/netty/handler/codec/ReplayingDecoder.java b/codec/src/main/java/io/netty/handler/codec/ReplayingDecoder.java
@@ -340,7 +340,8 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
                 cumulation = null;
             }
 
-            for (int i = 0; i < out.size(); i ++) {
+            int size = out.size();
+            for (int i = 0; i < size; i ++) {
                 ctx.fireChannelRead(out.get(i));
             }
             ctx.fireChannelInactive();