[netty#2215] DefaultChannelHandlerContext tasks needs to be volatile …

…to ensure every thread only see full initialized instances
opaopa6969 · Feb 8, 2014 · bd20f80 · bd20f80
1 parent d8c1409
commit bd20f80
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java b/transport/src/main/java/io/netty/channel/DefaultChannelHandlerContext.java
@@ -194,10 +194,12 @@ private static int skipFlags0(Class<? extends ChannelHandler> handlerType) {
     private ChannelFuture succeededFuture;
 
     // Lazily instantiated tasks used to trigger events to a handler with different executor.
-    Runnable invokeChannelReadCompleteTask;
-    Runnable invokeReadTask;
-    Runnable invokeFlushTask;
-    Runnable invokeChannelWritableStateChangedTask;
+    // These needs to be volatile as otherwise an other Thread may see an half initialized instance.
+    // See the JMM for more details
+    volatile Runnable invokeChannelReadCompleteTask;
+    volatile Runnable invokeReadTask;
+    volatile Runnable invokeFlushTask;
+    volatile Runnable invokeChannelWritableStateChangedTask;
 
     DefaultChannelHandlerContext(
             DefaultChannelPipeline pipeline, ChannelHandlerInvoker invoker, String name, ChannelHandler handler) {