Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input guard for flagging used input (JSON entries), raising exception when some remain unused #395

Merged
merged 29 commits into from
Mar 15, 2025

Conversation

Griger5
Copy link
Collaborator

@Griger5 Griger5 commented Jan 20, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.13%. Comparing base (0144d1a) to head (6239aa5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/input_guard.hpp 94.64% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   89.74%   90.13%   +0.38%     
==========================================
  Files          44       45       +1     
  Lines        2194     2270      +76     
  Branches      110      127      +17     
==========================================
+ Hits         1969     2046      +77     
+ Misses        160      156       -4     
- Partials       65       68       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Griger5 and others added 17 commits February 11, 2025 16:53
…SONGuard function can now call this function

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
…dding a warning if Julia not found + some notebook cleanups

Unverified

This user has not yet uploaded their public signing key.
@slayoo slayoo marked this pull request as ready for review March 15, 2025 05:59

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@slayoo slayoo added this pull request to the merge queue Mar 15, 2025
Merged via the queue into open-atmos:main with commit a4e5377 Mar 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants