fix: remove exception logging during evaluation

[beeme1mr]

This PR

• remove exception logging during evaluation

Impacts

open-telemetry/opentelemetry-demo#1628

Notes

The OTel demo was seeing overly verbose log messages when they disabled a flag. That's because a FLAG_NOT_FOUND error was raised by the provider, and the SDK was logging all exceptions. I've updated the SDK to no longer log OpenFeatureErrors since providers commonly raise these, which can lead to log spam. It's worth noting that this information can still be accessed via a hook or evaluation details.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (5c7bd14) to head (c4c3d3f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   97.41%   97.41%   -0.01%     
==========================================
  Files          26       26              
  Lines        1240     1239       -1     
==========================================
- Hits         1208     1207       -1     
  Misses         32       32              

Flag	Coverage Δ
unittests	97.41% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dyladan]

Is this affecting only the Python SDK or is it something that should be specified more generally?

[beeme1mr]

Is this affecting only the Python SDK or is it something that should be specified more generally?

Logging isn't covered in the spec. We could consider general guidance but I would be reluctant to go any deeper than that.

[toddbaert]

Is this affecting only the Python SDK or is it something that should be specified more generally?

After approving, I'm actually considering if we should specify something here. I'm wondering if this is the wrong solution to the problem.

I think we should be logging errors if a flag is not found, and that this change will make debugging harder. I think this is a situation where we'd want log-spam.

[toddbaert]

The Java SDK throws here: https://github.com/open-feature/java-sdk/blob/fc40209edcffc063a474aec7bfe9a880e0966750/src/main/java/dev/openfeature/sdk/OpenFeatureClient.java#L135C1-L136C1