Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] update mmcv maximum version to 1.8.0 #323

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Mar 2, 2023

In the current main branch, the maximum mmcv version is 1.7.0, which will cause installation and doc compiling failure after mmcv 1.7.1 is released.

@ly015 ly015 force-pushed the fix-mmcv-version branch from 6587502 to 4f10907 Compare March 2, 2023 03:13
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (0e0c2ce) 85.48% compared to head (ce15011) 85.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   85.48%   85.39%   -0.10%     
==========================================
  Files         208      211       +3     
  Lines       19642    20213     +571     
==========================================
+ Hits        16791    17260     +469     
- Misses       2851     2953     +102     
Flag Coverage Δ
unittests 85.39% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmhuman3d/__init__.py 76.47% <100.00%> (ø)

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 requested review from yl-1993 and caizhongang March 2, 2023 04:24
@caizhongang caizhongang requested a review from ttxskk March 16, 2023 10:19
docs/install.md Outdated
@@ -18,7 +18,7 @@
- CUDA 9.2+
- GCC 5+
- PyTorch3D 0.4+
- [MMCV](https://github.com/open-mmlab/mmcv) (Please install mmcv-full>=1.3.17,<1.6.0 for GPU)
- [MMCV](https://github.com/open-mmlab/mmcv) (Please install mmcv-full>=1.3.17,<1.8.0 for GPU)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully install MMHuman3D with the MMCV 1.7.1. but it requires us to choose the appropriate version of MMDet, MMTrack, MMPose, and MMCls.

Here is a successful case:
MMCV -> 1.7.1
MMDet -> 2.28.2
MMTrack -> 0.14.0
MMCls -> 0.25.0.

If we only change here, users will not be able to install MMHuman3D due to the compatibility of MMDet, MMTrack, and MMCls. So I think the suggested install command should stay the same or we change the installation command of other dependent libraries at the same time?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stay on low version in the official install.md, but allow higher mmcv to be used in the init.py.

@caizhongang caizhongang merged commit 9edb211 into open-mmlab:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants