-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] update mmcv maximum version to 1.8.0 #323
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
- Coverage 85.48% 85.39% -0.10%
==========================================
Files 208 211 +3
Lines 19642 20213 +571
==========================================
+ Hits 16791 17260 +469
- Misses 2851 2953 +102
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
docs/install.md
Outdated
@@ -18,7 +18,7 @@ | |||
- CUDA 9.2+ | |||
- GCC 5+ | |||
- PyTorch3D 0.4+ | |||
- [MMCV](https://github.com/open-mmlab/mmcv) (Please install mmcv-full>=1.3.17,<1.6.0 for GPU) | |||
- [MMCV](https://github.com/open-mmlab/mmcv) (Please install mmcv-full>=1.3.17,<1.8.0 for GPU) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I successfully install MMHuman3D with the MMCV 1.7.1. but it requires us to choose the appropriate version of MMDet, MMTrack, MMPose, and MMCls.
Here is a successful case:
MMCV -> 1.7.1
MMDet -> 2.28.2
MMTrack -> 0.14.0
MMCls -> 0.25.0.
If we only change here, users will not be able to install MMHuman3D due to the compatibility of MMDet, MMTrack, and MMCls. So I think the suggested install command should stay the same or we change the installation command of other dependent libraries at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's stay on low version in the official install.md, but allow higher mmcv to be used in the init.py.
In the current main branch, the maximum mmcv version is 1.7.0, which will cause installation and doc compiling failure after mmcv 1.7.1 is released.