-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update otel versions for prometheus to 0.27 #2309
base: main
Are you sure you want to change the base?
feat: update otel versions for prometheus to 0.27 #2309
Conversation
4800dd6
to
eda6bca
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
=======================================
- Coverage 79.5% 79.5% -0.1%
=======================================
Files 123 123
Lines 21479 21483 +4
=======================================
Hits 17084 17084
- Misses 4395 4399 +4 ☔ View full report in Codecov by Sentry. |
eda6bca
to
13ca8df
Compare
13ca8df
to
984b0d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I am requesting changes to fix the internal logs. These are now emitted via tracing
and most users likely have a tracing subscriber already enabled.. So we need to be very careful about emitting logs, especially the ones with high severity.
Also, try and make the descriptions more self-explanatory.(Totally understand these are existing issues, but just want to make it easier for end users to navigate the internal logs)
Enhanced error messages with specific names and differentiated warnings. Updated temporality method for Prometheus to always return cumulative temporality, aligning with Prometheus behavior.
Updated several error log names in `opentelemetry-prometheus/src/lib.rs` for better clarity and consistency. This includes renaming `AcquireLockError`, `ReaderError`, and `MetricValidation` to `MetricScrapeFailed` and `MetricValidationFailed`.
Changes
opentelemetry
dependency version to 0.27opentelemetry_sdk
dependency version to 0.27opentelemetry-semantic-conventions
dependency version to 0.27Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes