Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LogRecord fields private and add getters for encapsulation #2314

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 21, 2024

Changes

The PR refactors the LogRecord struct by making all its fields crate-private for better abstraction. Public getter methods have been added to provide controlled access to the fields.

TBD - Will add changelog, if the changes are agreed.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner November 21, 2024 00:17
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 85.24590% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (6b71301) to head (206dd7e).

Files with missing lines Patch % Lines
opentelemetry-stdout/src/logs/exporter.rs 0.0% 8 Missing ⚠️
opentelemetry-proto/src/transform/logs.rs 92.3% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2314   +/-   ##
=====================================
  Coverage   79.5%   79.5%           
=====================================
  Files        123     123           
  Lines      21492   21509   +17     
=====================================
+ Hits       17096   17113   +17     
  Misses      4396    4396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changelog as this is breaking export/processor authors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants