Feat/remove timeout from detectors #2332
Open
+22
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
=======================================
- Coverage 79.5% 79.5% -0.1%
=======================================
Files 123 123
Lines 21479 21473 -6
=======================================
- Hits 17084 17078 -6
Misses 4395 4395 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Nov 24, 2024
cijothomas
requested changes
Nov 24, 2024
cijothomas
reviewed
Dec 2, 2024
| @@ -13,6 +13,7 @@ | |||
| Released 2024-Nov-27 | |||
|
|
|||
| - **DEPRECATED**: | |||
| - `ResourceDetector.detect()` no longer supports timeout option. | |||
There was a problem hiding this comment.
need to move this to be under vnext.
cijothomas
reviewed
Dec 2, 2024
| @@ -155,7 +155,7 @@ impl<'a> UnsafeSlice<'a> { | |||
| #[inline(always)] | |||
| unsafe fn increment(&self, i: usize) { | |||
| let value = self.slice[i].get(); | |||
| (*value).count = (*value).count + 1; | |||
| (*value).count += 1; | |||
There was a problem hiding this comment.
nit: Please remove unrelated changes.
cijothomas
approved these changes
Dec 2, 2024
utpilla
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #2320, #2322
Changes
Remove the
ResourceDetector.detect()timeout option.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes