Fix: Regression after Ember 2.12 update for "Backtracking re-render" (…

…#55) That should do it.
open-tux · Apr 1, 2017 · 9afee52 · 9afee52
1 parent e569c7d
commit 9afee52
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/addon/components/bulma-checkbox.js b/addon/components/bulma-checkbox.js
@@ -4,11 +4,12 @@ import layout from '../templates/components/bulma-checkbox';
 
 const {
   get,
-  A: emberArray
+  set
 } = Ember;
 
 export default BulmaInput.extend({
   layout,
+
   classNames: ['checkbox'],
   type: 'checkbox',
   // Bindings are not comprehensive. More complex implementations should use a native element with classes applied
@@ -21,7 +22,8 @@ export default BulmaInput.extend({
   init() {
     this._super(...arguments);
 
-    // Removing the inherited input class name (as it breaks the styling)
-    emberArray(get(this, 'classNames')).removeObject('input');
+    // classNames reset
+    // Remove the inherited `input` class name (as it breaks the styling)
+    set(this, 'classNames', get(this, 'classNames').filter((name) => name !== 'input'));
   }
 });
diff --git a/addon/components/bulma-radio.js b/addon/components/bulma-radio.js
@@ -4,11 +4,12 @@ import layout from '../templates/components/bulma-checkbox';
 
 const {
   get,
-  A: emberArray
+  set
 } = Ember;
 
 export default BulmaInput.extend({
   layout,
+
   classNames: ['radio'],
   type: 'radio',
   // Bindings are not comprehensive. More complex implementations should use a native element with classes applied
@@ -21,7 +22,8 @@ export default BulmaInput.extend({
   init() {
     this._super(...arguments);
 
-    // Remove the inherited input class name (as it breaks the styling)
-    emberArray(get(this, 'classNames')).removeObject('input');
+    // classNames reset
+    // Remove the inherited `input` class name (as it breaks the styling)
+    set(this, 'classNames', get(this, 'classNames').filter((name) => name !== 'input'));
   }
 });