Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#57 switch build system from maven to gradle #69

Merged

Conversation

DivineThreepwood
Copy link
Member

📜 Description

Changes proposed in this pull request:

  • switch build system from maven to gradle
  • setup ci to
    • inspect code
    • build and test
    • publish to maven repos
  • cleanup maven stuff

DivineThreepwood and others added 30 commits March 2, 2022 21:13
@DivineThreepwood
Copy link
Member Author

Should not be merged yet since only a single artifact is deployed instead of each submodule. Still some investigation needed. However, the code review can already be performed.

@DivineThreepwood
Copy link
Member Author

DivineThreepwood commented Mar 22, 2022

All open issues are solved by not overwriting the artifact id for each submodule.

Copy link
Contributor

@pLeminoq pLeminoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Remove the second gradle wrapper and it will be approved.

@DivineThreepwood DivineThreepwood merged commit c1d8c81 into dev Mar 22, 2022
@DivineThreepwood DivineThreepwood deleted the feature/#57_switch_build_system_from_maven_to_gradle branch March 22, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants