Skip to content

Commit

Permalink
ASoC: kirkwood-dma: don't ignore other irq causes on error
Browse files Browse the repository at this point in the history
Ignoring the real cause of the interrupt is not a good idea; this
behaviour has been observed to bring Dove platforms to silently
lockup.  Instead, on error fall through to the normal interrupt
processing.

This is especially important on Dove platforms as errors are
handled separately, and allows us to clear down the real cause of
the interrupt.

Signed-off-by: Russell King <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
  • Loading branch information
Russell King authored and broonie committed Nov 21, 2012
1 parent ae6a5d3 commit 25ec6bb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sound/soc/kirkwood/kirkwood-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id)
printk(KERN_WARNING "%s: got err interrupt 0x%lx\n",
__func__, cause);
writel(cause, priv->io + KIRKWOOD_ERR_CAUSE);
return IRQ_HANDLED;
}

/* we've enabled only bytes interrupts ... */
Expand Down

0 comments on commit 25ec6bb

Please sign in to comment.