Skip to content

Commit

Permalink
ipc/shm.c: is_file_shm_hugepages() can be boolean
Browse files Browse the repository at this point in the history
Make is_file_shm_hugepages() return bool to improve readability due to
this particular function only using either one or zero as its return
value.

No functional change.

Signed-off-by: Yaowei Bai <[email protected]>
Acked-by: Michal Hocko <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Yaowei Bai authored and torvalds committed Jan 21, 2016
1 parent 06af1c5 commit 2954e44
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions include/linux/shm.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ struct sysv_shm {

long do_shmat(int shmid, char __user *shmaddr, int shmflg, unsigned long *addr,
unsigned long shmlba);
int is_file_shm_hugepages(struct file *file);
bool is_file_shm_hugepages(struct file *file);
void exit_shm(struct task_struct *task);
#define shm_init_task(task) INIT_LIST_HEAD(&(task)->sysvshm.shm_clist)
#else
Expand All @@ -66,9 +66,9 @@ static inline long do_shmat(int shmid, char __user *shmaddr,
{
return -ENOSYS;
}
static inline int is_file_shm_hugepages(struct file *file)
static inline bool is_file_shm_hugepages(struct file *file)
{
return 0;
return false;
}
static inline void exit_shm(struct task_struct *task)
{
Expand Down
2 changes: 1 addition & 1 deletion ipc/shm.c
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ static const struct file_operations shm_file_operations_huge = {
.fallocate = shm_fallocate,
};

int is_file_shm_hugepages(struct file *file)
bool is_file_shm_hugepages(struct file *file)
{
return file->f_op == &shm_file_operations_huge;
}
Expand Down

0 comments on commit 2954e44

Please sign in to comment.