Skip to content

Commit

Permalink
EDAC, octeon: Fix an uninitialized variable warning
Browse files Browse the repository at this point in the history
Fix an uninitialized variable warning in the Octeon EDAC driver, as seen
in MIPS cavium_octeon_defconfig builds since v4.14 with Codescape GNU
Tools 2016.05-03:

  drivers/edac/octeon_edac-lmc.c In function ‘octeon_lmc_edac_poll_o2’:
  drivers/edac/octeon_edac-lmc.c:87:24: warning: ‘((long unsigned int*)&int_reg)[1]’ may \
    be used uninitialized in this function [-Wmaybe-uninitialized]
    if (int_reg.s.sec_err || int_reg.s.ded_err) {
                        ^
Iinitialise the whole int_reg variable to zero before the conditional
assignments in the error injection case.

Signed-off-by: James Hogan <[email protected]>
Acked-by: David Daney <[email protected]>
Cc: linux-edac <[email protected]>
Cc: [email protected]
Cc: <[email protected]> # 3.15+
Fixes: 1bc021e ("EDAC: Octeon: Add error injection support")
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Borislav Petkov <[email protected]>
  • Loading branch information
amalon authored and suryasaimadhu committed Nov 27, 2017
1 parent 4fbd8d1 commit 544e925
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/edac/octeon_edac-lmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ static void octeon_lmc_edac_poll_o2(struct mem_ctl_info *mci)
if (!pvt->inject)
int_reg.u64 = cvmx_read_csr(CVMX_LMCX_INT(mci->mc_idx));
else {
int_reg.u64 = 0;
if (pvt->error_type == 1)
int_reg.s.sec_err = 1;
if (pvt->error_type == 2)
Expand Down

0 comments on commit 544e925

Please sign in to comment.