Skip to content

Commit

Permalink
ipc: rename ipc_obtain_object
Browse files Browse the repository at this point in the history
...  to ipc_obtain_object_idr, which is more meaningful and makes the code
slightly easier to follow.

Signed-off-by: Davidlohr Bueso <[email protected]>
Cc: Manfred Spraul <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Davidlohr Bueso authored and torvalds committed Jul 1, 2015
1 parent ff35e5e commit 55b7ae5
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion ipc/msg.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ struct msg_sender {

static inline struct msg_queue *msq_obtain_object(struct ipc_namespace *ns, int id)
{
struct kern_ipc_perm *ipcp = ipc_obtain_object(&msg_ids(ns), id);
struct kern_ipc_perm *ipcp = ipc_obtain_object_idr(&msg_ids(ns), id);

if (IS_ERR(ipcp))
return ERR_CAST(ipcp);
Expand Down
4 changes: 2 additions & 2 deletions ipc/sem.c
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ static inline struct sem_array *sem_obtain_lock(struct ipc_namespace *ns,
struct kern_ipc_perm *ipcp;
struct sem_array *sma;

ipcp = ipc_obtain_object(&sem_ids(ns), id);
ipcp = ipc_obtain_object_idr(&sem_ids(ns), id);
if (IS_ERR(ipcp))
return ERR_CAST(ipcp);

Expand All @@ -410,7 +410,7 @@ static inline struct sem_array *sem_obtain_lock(struct ipc_namespace *ns,

static inline struct sem_array *sem_obtain_object(struct ipc_namespace *ns, int id)
{
struct kern_ipc_perm *ipcp = ipc_obtain_object(&sem_ids(ns), id);
struct kern_ipc_perm *ipcp = ipc_obtain_object_idr(&sem_ids(ns), id);

if (IS_ERR(ipcp))
return ERR_CAST(ipcp);
Expand Down
2 changes: 1 addition & 1 deletion ipc/shm.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ void __init shm_init(void)

static inline struct shmid_kernel *shm_obtain_object(struct ipc_namespace *ns, int id)
{
struct kern_ipc_perm *ipcp = ipc_obtain_object(&shm_ids(ns), id);
struct kern_ipc_perm *ipcp = ipc_obtain_object_idr(&shm_ids(ns), id);

if (IS_ERR(ipcp))
return ERR_CAST(ipcp);
Expand Down
8 changes: 4 additions & 4 deletions ipc/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ void ipc64_perm_to_ipc_perm(struct ipc64_perm *in, struct ipc_perm *out)
* Call inside the RCU critical section.
* The ipc object is *not* locked on exit.
*/
struct kern_ipc_perm *ipc_obtain_object(struct ipc_ids *ids, int id)
struct kern_ipc_perm *ipc_obtain_object_idr(struct ipc_ids *ids, int id)
{
struct kern_ipc_perm *out;
int lid = ipcid_to_idx(id);
Expand All @@ -581,7 +581,7 @@ struct kern_ipc_perm *ipc_lock(struct ipc_ids *ids, int id)
struct kern_ipc_perm *out;

rcu_read_lock();
out = ipc_obtain_object(ids, id);
out = ipc_obtain_object_idr(ids, id);
if (IS_ERR(out))
goto err1;

Expand All @@ -605,15 +605,15 @@ struct kern_ipc_perm *ipc_lock(struct ipc_ids *ids, int id)
* @ids: ipc identifier set
* @id: ipc id to look for
*
* Similar to ipc_obtain_object() but also checks
* Similar to ipc_obtain_object_idr() but also checks
* the ipc object reference counter.
*
* Call inside the RCU critical section.
* The ipc object is *not* locked on exit.
*/
struct kern_ipc_perm *ipc_obtain_object_check(struct ipc_ids *ids, int id)
{
struct kern_ipc_perm *out = ipc_obtain_object(ids, id);
struct kern_ipc_perm *out = ipc_obtain_object_idr(ids, id);

if (IS_ERR(out))
goto out;
Expand Down
2 changes: 1 addition & 1 deletion ipc/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ void ipc_rcu_putref(void *ptr, void (*func)(struct rcu_head *head));
void ipc_rcu_free(struct rcu_head *head);

struct kern_ipc_perm *ipc_lock(struct ipc_ids *, int);
struct kern_ipc_perm *ipc_obtain_object(struct ipc_ids *ids, int id);
struct kern_ipc_perm *ipc_obtain_object_idr(struct ipc_ids *ids, int id);

void kernel_to_ipc64_perm(struct kern_ipc_perm *in, struct ipc64_perm *out);
void ipc64_perm_to_ipc_perm(struct ipc64_perm *in, struct ipc_perm *out);
Expand Down

0 comments on commit 55b7ae5

Please sign in to comment.