Skip to content

Commit

Permalink
of/irq: fix guards for irq_of_parse_and_map prototype
Browse files Browse the repository at this point in the history
Since OF is now a userselectable config symbol, having OF=y but OF_IRQ=n
is a valid combination for non-OF platforms, and OF=y does not guarantee
anymore that OF_IRQ is enabled (or we are building for SPARC).

Fixes the following build error with OF=y, IRQ_DOMAIN=n and SPI=y:

drivers/built-in.o: In function `spi_register_master':
(.text+0xc3ae): undefined reference to `irq_of_parse_and_map'
Makefile:935: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1

Signed-off-by: Jonas Gorski <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
  • Loading branch information
KanjiMonster authored and robherring committed Oct 13, 2015
1 parent 52493d4 commit 62ebf93
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/linux/of_irq.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ static inline void of_msi_configure(struct device *dev, struct device_node *np)
}
#endif

#if defined(CONFIG_OF)
#if defined(CONFIG_OF_IRQ) || defined(CONFIG_SPARC)
/*
* irq_of_parse_and_map() is used by all OF enabled platforms; but SPARC
* implements it differently. However, the prototype is the same for all,
* so declare it here regardless of the CONFIG_OF_IRQ setting.
*/
extern unsigned int irq_of_parse_and_map(struct device_node *node, int index);

#else /* !CONFIG_OF */
#else /* !CONFIG_OF && !CONFIG_SPARC */
static inline unsigned int irq_of_parse_and_map(struct device_node *dev,
int index)
{
Expand Down

0 comments on commit 62ebf93

Please sign in to comment.