Skip to content

Commit

Permalink
cfg80211: remove macro ASSERT_RDEV_LOCK(rdev)
Browse files Browse the repository at this point in the history
Macro ASSERT_RDEV_LOCK(rdev) is equal to ASSERT_RTNL(), so replace it
with ASSERT_RTNL() and remove it.

Signed-off-by: Zhao, Gang <[email protected]>
Signed-off-by: Johannes Berg <[email protected]>
  • Loading branch information
zhao-gang authored and jmberg-intel committed Mar 19, 2014
1 parent 4da6462 commit 73fb08e
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion net/wireless/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ static inline void wdev_unlock(struct wireless_dev *wdev)
mutex_unlock(&wdev->mtx);
}

#define ASSERT_RDEV_LOCK(rdev) ASSERT_RTNL()
#define ASSERT_WDEV_LOCK(wdev) lockdep_assert_held(&(wdev)->mtx)

static inline bool cfg80211_has_monitors_only(struct cfg80211_registered_device *rdev)
Expand Down
1 change: 0 additions & 1 deletion net/wireless/sme.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ static int cfg80211_conn_scan(struct wireless_dev *wdev)
int n_channels, err;

ASSERT_RTNL();
ASSERT_RDEV_LOCK(rdev);
ASSERT_WDEV_LOCK(wdev);

if (rdev->scan_req || rdev->scan_msg)
Expand Down
3 changes: 1 addition & 2 deletions net/wireless/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,6 @@ void cfg80211_process_rdev_events(struct cfg80211_registered_device *rdev)
struct wireless_dev *wdev;

ASSERT_RTNL();
ASSERT_RDEV_LOCK(rdev);

list_for_each_entry(wdev, &rdev->wdev_list, list)
cfg80211_process_wdev_events(wdev);
Expand All @@ -851,7 +850,7 @@ int cfg80211_change_iface(struct cfg80211_registered_device *rdev,
int err;
enum nl80211_iftype otype = dev->ieee80211_ptr->iftype;

ASSERT_RDEV_LOCK(rdev);
ASSERT_RTNL();

/* don't support changing VLANs, you just re-create them */
if (otype == NL80211_IFTYPE_AP_VLAN)
Expand Down
2 changes: 1 addition & 1 deletion net/wireless/wext-sme.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ int cfg80211_mgd_wext_connect(struct cfg80211_registered_device *rdev,
const u8 *prev_bssid = NULL;
int err, i;

ASSERT_RDEV_LOCK(rdev);
ASSERT_RTNL();
ASSERT_WDEV_LOCK(wdev);

if (!netif_running(wdev->netdev))
Expand Down

0 comments on commit 73fb08e

Please sign in to comment.