Skip to content

Commit

Permalink
bpf: Fix tcp_synrto_kern.c sample program
Browse files Browse the repository at this point in the history
The program was returning -1 in some cases which is not allowed
by the verifier any longer.

Fixes: 390ee7e ("bpf: enforce return code for cgroup-bpf programs")
Signed-off-by: Lawrence Brakmo <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Lawrence Brakmo authored and davem330 committed Nov 11, 2017
1 parent 8d6e79d commit 7863f46
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions samples/bpf/tcp_synrto_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ int bpf_synrto(struct bpf_sock_ops *skops)
* if neither port numberis 55601
*/
if (bpf_ntohl(skops->remote_port) != 55601 &&
skops->local_port != 55601)
return -1;
skops->local_port != 55601) {
skops->reply = -1;
return 1;
}

op = (int) skops->op;

Expand Down

0 comments on commit 7863f46

Please sign in to comment.