Skip to content

Commit

Permalink
ktest: Place quotes around item variable
Browse files Browse the repository at this point in the history
Seems that some of the new console logic causes doprint to possibly
get evaluated. When printing a commit message that contains parenthesis,
it fails with a shell parsing error.

This gets fixed when we add quotes around the $item variable, and prevent
it from being evaluated by any shell commands.

Signed-off-by: Steven Rostedt <[email protected]>
  • Loading branch information
rostedt committed Feb 3, 2015
1 parent 1cb9e64 commit 7c2c49e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/ktest/ktest.pl
Original file line number Diff line number Diff line change
Expand Up @@ -3447,7 +3447,7 @@ sub patchcheck {
my $sha1 = $item;
$sha1 =~ s/^([[:xdigit:]]+).*/$1/;

doprint "\nProcessing commit $item\n\n";
doprint "\nProcessing commit \"$item\"\n\n";

run_command "git checkout $sha1" or
die "Failed to checkout $sha1";
Expand Down

0 comments on commit 7c2c49e

Please sign in to comment.