net: sched: silence uninitialized parent variable warning in tc_dump_…

…tfilter When tcm->tcm_ifindex == TCM_IFINDEX_MAGIC_BLOCK, parent is still passed down but the value is never used. Compiler does not recognize it and issues a warning. Silence it down initializing parent to 0. Fixes: 7960d1d ("net: sched: use block index as a handle instead of qdisc when block is shared") Reported-by: David Miller <[email protected]> Reported-by: Stephen Rothwell <[email protected]> Signed-off-by: Jiri Pirko <[email protected]> Signed-off-by: David S. Miller <[email protected]>
opendata26 · Jan 18, 2018 · d680b35 · d680b35
1 parent 4f7d585
commit d680b35
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
@@ -1317,6 +1317,13 @@ static int tc_dump_tfilter(struct sk_buff *skb, struct netlink_callback *cb)
 		block = tcf_block_lookup(net, tcm->tcm_block_index);
 		if (!block)
 			goto out;
+		/* If we work with block index, q is NULL and parent value
+		 * will never be used in the following code. The check
+		 * in tcf_fill_node prevents it. However, compiler does not
+		 * see that far, so set parent to zero to silence the warning
+		 * about parent being uninitialized.
+		 */
+		parent = 0;
 	} else {
 		const struct Qdisc_class_ops *cops;
 		struct net_device *dev;