Skip to content

Commit

Permalink
ARM: dts: armada-388-clearfog: number LAN ports properly
Browse files Browse the repository at this point in the history
Currently, the ports as seen from the rear number as:

	eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6

which is illogical - this came about because the rev 2.0 boards have the
LEDs on the front for the DSA switch (lan5-1) reversed.  Rev 2.1 boards
fixed the LED issue, and the Clearfog case numbers the lan ports
increasing from left to right.

Maintaining this illogical numbering causes confusion, with reports that
"my link isn't coming up" and "my connection negotiates 10base-Half"
both of which are due to people thinking that the port next to the SFP
is lan1.

Fix this by renumbering the ports to match people's expectations.

[[email protected]: added the Fixes and stable tags]

Fixes: 4c945e8 ("ARM: dts: Add SolidRun Armada 388 Clearfog A1 DT
file")
Cc: <[email protected]>

Signed-off-by: Russell King <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: Gregory CLEMENT <[email protected]>
  • Loading branch information
Russell King authored and gclement committed Aug 8, 2016
1 parent 29b4817 commit d9fd3c9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions arch/arm/boot/dts/armada-388-clearfog.dts
Original file line number Diff line number Diff line change
Expand Up @@ -390,12 +390,12 @@

port@0 {
reg = <0>;
label = "lan1";
label = "lan5";
};

port@1 {
reg = <1>;
label = "lan2";
label = "lan4";
};

port@2 {
Expand All @@ -405,12 +405,12 @@

port@3 {
reg = <3>;
label = "lan4";
label = "lan2";
};

port@4 {
reg = <4>;
label = "lan5";
label = "lan1";
};

port@5 {
Expand Down

0 comments on commit d9fd3c9

Please sign in to comment.