Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a race condition by explicitly coping Torch forces #16

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Fix a race condition by explicitly coping Torch forces #16

merged 3 commits into from
Aug 6, 2020

Conversation

raimis
Copy link
Contributor

@raimis raimis commented Aug 5, 2020

Fix #13

@raimis raimis mentioned this pull request Aug 5, 2020
Closed
@peastman
Copy link
Member

peastman commented Aug 5, 2020

That looks great, and it fixes the problem for me to. If you mark this as no longer a draft I'll merge it.

@raimis raimis marked this pull request as ready for review August 6, 2020 09:58
@raimis
Copy link
Contributor Author

raimis commented Aug 6, 2020

Ideally, I should make a test, but added just a comment to keep that Tensor::clone from being optimised out.

@peastman peastman merged commit 27e845c into openmm:master Aug 6, 2020
@peastman
Copy link
Member

peastman commented Aug 6, 2020

Thanks so much for tracking this down!

@peastman peastman mentioned this pull request Aug 6, 2020
Closed
@yaoyic yaoyic mentioned this pull request Sep 30, 2020
Merged
@raimis raimis mentioned this pull request Jul 9, 2021
Closed
@dmighty007 dmighty007 mentioned this pull request Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple simulations on the same GPU are interfering with each other!
2 participants
@raimis @peastman