-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Models can directly output forces #52
Conversation
I'm not sure what's causing the CI failures. The Linux build gets this error:
It looks like PyTorch is compiled against a very old version of glibc that isn't available on the build machine. But we get it from conda-forge, so shouldn't it use the same version as everything else? The Mac build fails with this error when building the Python package.
I don't understand that. It claims to have just installed openmmtorch 1.0, and then immediately says that it can't find openmmtorch 1.0. Any idea what's causing either of these? |
I'll try to solved the CI issue with #53 |
CI is passing. Any comments on this, or should I merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Thanks! |
Fixes #48. This allows the model to optionally return both energy and forces, instead of relying on backpropagation for the forces.