Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models can directly output forces #52

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Conversation

peastman
Copy link
Member

@peastman peastman commented Jan 3, 2022

Fixes #48. This allows the model to optionally return both energy and forces, instead of relying on backpropagation for the forces.

@peastman
Copy link
Member Author

peastman commented Jan 4, 2022

I'm not sure what's causing the CI failures. The Linux build gets this error:

/usr/share/miniconda/envs/build/bin/../lib/gcc/x86_64-conda-linux-gnu/9.4.0/../../../../x86_64-conda-linux-gnu/bin/ld: /usr/share/miniconda/envs/build/lib/python3.7/site-packages/torch/lib/libtorch_cpu.so: undefined reference to `memcpy@GLIBC_2.14'

It looks like PyTorch is compiled against a very old version of glibc that isn't available on the build machine. But we get it from conda-forge, so shouldn't it use the same version as everything else?

The Mac build fails with this error when building the Python package.

Installed /usr/local/miniconda/envs/build/lib/python3.9/site-packages/openmmtorch-1.0-py3.9-macosx-10.9-x86_64.egg
Processing dependencies for openmmtorch==1.0
Searching for openmmtorch==1.0
Reading https://pypi.org/simple/openmmtorch/
Couldn't find index page for 'openmmtorch' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
No local packages or working download links found for openmmtorch==1.0
error: Could not find suitable distribution for Requirement.parse('openmmtorch==1.0')

I don't understand that. It claims to have just installed openmmtorch 1.0, and then immediately says that it can't find openmmtorch 1.0.

Any idea what's causing either of these?

@raimis
Copy link
Contributor

raimis commented Jan 7, 2022

I'll try to solved the CI issue with #53

@peastman
Copy link
Member Author

peastman commented Jan 7, 2022

CI is passing. Any comments on this, or should I merge it?

Copy link
Contributor

@raimis raimis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@peastman peastman merged commit 1316c05 into openmm:master Jan 10, 2022
@peastman peastman deleted the forces branch January 10, 2022 16:42
@peastman
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the ML model to compute forces explicitly
2 participants