Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Make prettier Stats #24

Closed
wants to merge 1 commit into from
Closed

WIP Make prettier Stats #24

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 29, 2019

No description provided.

@ghost ghost self-assigned this Mar 29, 2019
@ghost
Copy link
Author

ghost commented Mar 29, 2019

prettier-stats

@rhiaro @ScatteredInk @kd-ods @Bjwebb Comments?

@Bjwebb
Copy link
Collaborator

Bjwebb commented Apr 2, 2019

Looks fine to me.

@kd-ods
Copy link
Collaborator

kd-ods commented Apr 2, 2019

I'd prefer to leave all the 'Statistics' in a single section, rather than splitting them out into 'Statistics: Entity...'. 'Statistics: People...' and so on. (The reason being that we then have a proliferation of sections at the same level of importance as - e.g. - 'Validation errors')

Subheadings within a single 'Statistics' section would do for now. And could we rename the Statistics section to 'Content review' for now, too? It's a bit more friendly and meaningful.

(The next BODS CoVE sprint will be a chance to work on all of the aspects of presentation.)

ghost pushed a commit that referenced this pull request Apr 2, 2019
Based on feedback in #24
@ghost
Copy link
Author

ghost commented Apr 2, 2019

I have had a first go at this in #28

@ghost
Copy link
Author

ghost commented Apr 2, 2019

From #28:

28-1

28-2

28-3

@kd-ods
Copy link
Collaborator

kd-ods commented Apr 3, 2019

Looks good - thanks, @odscjames!

@ghost ghost changed the title Make prettier Stats WIP Make prettier Stats Apr 4, 2019
ghost pushed a commit that referenced this pull request Apr 9, 2019
Based on feedback in #24
ghost pushed a commit that referenced this pull request Apr 9, 2019
Based on feedback in #24
@ghost
Copy link
Author

ghost commented Jul 9, 2019

Closing - think all the work was done in #28

@ghost ghost closed this Jul 9, 2019
@BibianaC BibianaC deleted the reformat-stats branch April 9, 2020 13:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants